Messages in this thread Patch in this message | | | From | Arnd Bergmann <> | Subject | [PATCH] dwc3: make PM functions as __maybe_unused | Date | Tue, 15 Nov 2016 17:05:43 +0100 |
| |
A change to the suspend/resume handling in dwc3-pci introduced a harmless warning:
drivers/usb/dwc3/dwc3-pci.c:169:12: error: ‘dwc3_pci_dsm’ defined but not used [-Werror=unused-function]
Replacing the #ifdef around the PM functions with __maybe_unused annotations is the easiest way to make sure this doesn't happen again. A similar problem happened two months earlier and we ended up updating the #ifdef, but as it has come back now, I'd suggest going back to my earlier approach.
Fixes: 9cecca75b5a0 ("usb: dwc3: pci: call _DSM for suspend/resume") Link: https://patchwork.kernel.org/patch/9318887/ Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/usb/dwc3/dwc3-pci.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index 8c39ec6522fd..771b620b4878 100644 --- a/drivers/usb/dwc3/dwc3-pci.c +++ b/drivers/usb/dwc3/dwc3-pci.c @@ -293,8 +293,7 @@ static const struct pci_device_id dwc3_pci_id_table[] = { }; MODULE_DEVICE_TABLE(pci, dwc3_pci_id_table); -#ifdef CONFIG_PM -static int dwc3_pci_runtime_suspend(struct device *dev) +static int __maybe_unused dwc3_pci_runtime_suspend(struct device *dev) { struct dwc3_pci *dwc = dev_get_drvdata(dev); @@ -304,7 +303,7 @@ static int dwc3_pci_runtime_suspend(struct device *dev) return -EBUSY; } -static int dwc3_pci_runtime_resume(struct device *dev) +static int __maybe_unused dwc3_pci_runtime_resume(struct device *dev) { struct dwc3_pci *dwc = dev_get_drvdata(dev); struct platform_device *dwc3 = dwc->dwc3; @@ -316,23 +315,20 @@ static int dwc3_pci_runtime_resume(struct device *dev) return pm_runtime_get(&dwc3->dev); } -#endif /* CONFIG_PM */ -#ifdef CONFIG_PM_SLEEP -static int dwc3_pci_suspend(struct device *dev) +static int __maybe_unused dwc3_pci_suspend(struct device *dev) { struct dwc3_pci *dwc = dev_get_drvdata(dev); return dwc3_pci_dsm(dwc, PCI_INTEL_BXT_STATE_D3); } -static int dwc3_pci_resume(struct device *dev) +static int __maybe_unused dwc3_pci_resume(struct device *dev) { struct dwc3_pci *dwc = dev_get_drvdata(dev); return dwc3_pci_dsm(dwc, PCI_INTEL_BXT_STATE_D0); } -#endif /* CONFIG_PM_SLEEP */ static struct dev_pm_ops dwc3_pci_dev_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(dwc3_pci_suspend, dwc3_pci_resume) -- 2.9.0
| |