lkml.org 
[lkml]   [2016]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 5/5] wcn36xx: Don't use the destroyed hal_mutex
    Date
    ieee80211_unregister_hw() might invoke operations to stop the interface,
    that uses the hal_mutex. So don't destroy it until after we're done
    using it.

    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    ---

    With this patch I can successfully (although with a SMD send timeout in the
    shutdown path) start and stop the WCNSS PIL/remoteproc multiple times and the
    wlan0 interface will come and go accordingly.

    Will submit the necessary DT patches soon as well.

    Changes since v4:
    - New patch

    drivers/net/wireless/ath/wcn36xx/main.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
    index 96a9584edcbb..0002190c9041 100644
    --- a/drivers/net/wireless/ath/wcn36xx/main.c
    +++ b/drivers/net/wireless/ath/wcn36xx/main.c
    @@ -1241,7 +1241,6 @@ static int wcn36xx_remove(struct platform_device *pdev)
    wcn36xx_dbg(WCN36XX_DBG_MAC, "platform remove\n");

    release_firmware(wcn->nv);
    - mutex_destroy(&wcn->hal_mutex);

    ieee80211_unregister_hw(hw);

    @@ -1250,6 +1249,8 @@ static int wcn36xx_remove(struct platform_device *pdev)

    iounmap(wcn->dxe_base);
    iounmap(wcn->ccu_base);
    +
    + mutex_destroy(&wcn->hal_mutex);
    ieee80211_free_hw(hw);

    return 0;
    --
    2.5.0
    \
     
     \ /
      Last update: 2016-11-15 07:07    [W:4.390 / U:0.908 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site