Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 15 Nov 2016 10:15:01 +0100 | Subject | Re: [PATCH] pinctrl: sunxi: Free configs in pinctrl_map only if it is a config map |
| |
On Fri, Nov 11, 2016 at 3:35 AM, Chen-Yu Tsai <wens@csie.org> wrote:
> In the recently refactored sunxi pinctrl library, we are only allocating > one set of pin configs for each pinmux setting node. When the pinctrl_map > structure is freed, the pin configs should also be freed. However the > code assumed the first map would contain the configs, which actually > never happens, as the mux function map gets added first. > > The proper way to do this is to look through all the maps and free the > first one whose type is actually PIN_MAP_TYPE_CONFIGS_GROUP. > > Also slightly expand the comment explaining this. > > Fixes: f233dbca6227 ("pinctrl: sunxi: Rework the pin config building code") > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Patch applied with Maxime's ACK.
Yours, Linus Walleij
| |