Messages in this thread | | | From | KY Srinivasan <> | Subject | RE: [PATCH 1/3] PCI: hv: use the correct buffer size in new_pcichild_device() | Date | Mon, 14 Nov 2016 22:58:55 +0000 |
| |
> -----Original Message----- > From: Dexuan Cui > Sent: Wednesday, November 9, 2016 11:18 PM > To: Bjorn Helgaas <bhelgaas@google.com>; linux-pci@vger.kernel.org; > devel@linuxdriverproject.org > Cc: gregkh@linuxfoundation.org; KY Srinivasan <kys@microsoft.com>; > Haiyang Zhang <haiyangz@microsoft.com>; Stephen Hemminger > <sthemmin@microsoft.com>; Jake Oshins <jakeo@microsoft.com>; Hadden > Hoppert <haddenh@microsoft.com>; Vitaly Kuznetsov > <vkuznets@redhat.com>; jasowang@redhat.com; apw@canonical.com; > olaf@aepfle.de; linux-kernel@vger.kernel.org > Subject: [PATCH 1/3] PCI: hv: use the correct buffer size in > new_pcichild_device() > > We don't really need such a big on-stack buffer. > vmbus_sendpacket() here only uses sizeof(struct pci_child_message). > > Signed-off-by: Dexuan Cui <decui@microsoft.com> > CC: Jake Oshins <jakeo@microsoft.com> > Cc: KY Srinivasan <kys@microsoft.com> > CC: Haiyang Zhang <haiyangz@microsoft.com> > CC: Vitaly Kuznetsov <vkuznets@redhat.com>
Thanks Dexuan.
Acked-by: K. Y. Srinivasan <kys@microsoft.com>
> --- > drivers/pci/host/pci-hyperv.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c > index 763ff87..93ed64a 100644 > --- a/drivers/pci/host/pci-hyperv.c > +++ b/drivers/pci/host/pci-hyperv.c > @@ -1271,9 +1271,9 @@ static struct hv_pci_dev > *new_pcichild_device(struct hv_pcibus_device *hbus, > struct hv_pci_dev *hpdev; > struct pci_child_message *res_req; > struct q_res_req_compl comp_pkt; > - union { > - struct pci_packet init_packet; > - u8 buffer[0x100]; > + struct { > + struct pci_packet init_packet; > + u8 buffer[sizeof(struct pci_child_message)]; > } pkt; > unsigned long flags; > int ret; > -- > 2.7.4
| |