Messages in this thread | | | Date | Mon, 14 Nov 2016 06:49:44 -0800 | From | Andi Kleen <> | Subject | Re: [PATCH v4 0/6] perf report: Show branch flags/cycles in --branch-history callgraph view |
| |
On Mon, Nov 14, 2016 at 11:30:56AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Oct 31, 2016 at 09:19:48AM +0800, Jin Yao escreveu: > > v4: Update according to Andi's comments. The requirement is not displaying > > the number of removed loops. It needs to display the average number of > > iterations. It computes out the number of iterations by counting > > the removed loops. > > > > v3: 1. Display the count for tsx abort, remove the abort percentage. > > > > 2. Since the branch history code has a loop detection that removes > > small loops in util/machine.c:remove_loops(). It would be nice to > > note how many loops were removed. So it adds the note on some > > callchain entries. > > > > v2: Just a rebase to Arnaldo's perf/core branch, no functional changes. > > Andi, are you ok with this now? Can I have your Acked-by or Tested-by?
Yes it looks good to me now.
Acked-by: Andi Kleen <ak@linux.intel.com>
-Andi
| |