lkml.org 
[lkml]   [2016]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: fsnotify_mark_srcu wtf?
On Sun, Nov 13, 2016 at 8:43 PM, Amir Goldstein <amir73il@gmail.com> wrote:
> On Thu, Nov 10, 2016 at 9:46 PM, Jan Kara <jack@suse.cz> wrote:
>
> ...
>
>>
>> Well but how would you like to protect the mark list hanging off the inode
>> / mountpoint with two SRCUs? You'd need two lists hanging off the inode &
>> mountpoint (for different priorities) and that's too big cost to pay to
>> accomodate broken userspace...
>>
>
> This is the plan.
> I have a rough implementation, which still requires some testing:
>

2 patches posted:
fsnotify: separate fsnotify_mark_srcu for groups with permission events
fsnotify: handle permission events without holding fsnotify_mark_srcu[0]

Miklos,

Your test program actually passes after the first patch (split to 2 SRCU)
but only because it does not add any inotify mark, so I modified your test
a bit and made it available on my github:
https://github.com/amir73il/fsnotify-utils/blob/master/fanotify_bug.c

Jan,

Please let me know what you think of this version.

Thanks,
Amir.

\
 
 \ /
  Last update: 2016-11-14 13:00    [W:0.094 / U:26.792 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site