Messages in this thread | | | Date | Mon, 14 Nov 2016 21:30:01 -0700 | From | Jason Gunthorpe <> | Subject | Re: [PATCH] tpm: drop chip->is_open and chip->duration_adjusted |
| |
On Mon, Nov 14, 2016 at 03:44:58PM -0800, Jarkko Sakkinen wrote: > Use atomic bitops for chip->flags so that we do not need chip->is_open > and chip->duration_adjusted anymore.
I don't know if it s a really great idea to use atomic bit ops for things that do not need to be atomic.. It makes the locking scheme less clear. is open is genuinely different since it relies on the atomic for correctness.
Merging is_duration makes lots of sense though
Jason
| |