lkml.org 
[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 091/346] brcmsmac: Initialize power in brcms_c_stf_ss_algo_channel_get()
    3.16.39-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Florian Fainelli <f.fainelli@gmail.com>

    commit f823a2aa8f4674c095a5413b9e3ba12d82df06f2 upstream.

    wlc_phy_txpower_get_current() does a logical OR of power->flags, which
    presumes that power.flags was initiliazed earlier by the caller,
    unfortunately, this is not the case, so make sure we zero out the struct
    tx_power before calling into wlc_phy_txpower_get_current().

    Reported-by: coverity (CID 146011)
    Fixes: 5b435de0d7868 ("net: wireless: add brcm80211 drivers")
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    [bwh: Backported to 3.16: adjust filename]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/wireless/brcm80211/brcmsmac/stf.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/wireless/brcm80211/brcmsmac/stf.c
    +++ b/drivers/net/wireless/brcm80211/brcmsmac/stf.c
    @@ -87,7 +87,7 @@ void
    brcms_c_stf_ss_algo_channel_get(struct brcms_c_info *wlc, u16 *ss_algo_channel,
    u16 chanspec)
    {
    - struct tx_power power;
    + struct tx_power power = { };
    u8 siso_mcs_id, cdd_mcs_id, stbc_mcs_id;

    /* Clear previous settings */
    \
     
     \ /
      Last update: 2016-11-14 04:54    [W:4.022 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site