lkml.org 
[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 173/346] usb: gadget: fsl_qe_udc: off by one in setup_received_handle()
    3.16.39-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 7442e6db5bdd0dce4615205508301f9b22e502d6 upstream.

    The udc->eps[] array has USB_MAX_ENDPOINTS elements so > should be >=.

    Fixes: 3948f0e0c999 ('usb: add Freescale QE/CPM USB peripheral controller driver')
    Acked-by: Peter Chen <peter.chen@nxp.com>
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
    [bwh: Backported to 3.16: adjust filename]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/gadget/fsl_qe_udc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/gadget/fsl_qe_udc.c
    +++ b/drivers/usb/gadget/fsl_qe_udc.c
    @@ -2057,7 +2057,7 @@ static void setup_received_handle(struct
    struct qe_ep *ep;

    if (wValue != 0 || wLength != 0
    - || pipe > USB_MAX_ENDPOINTS)
    + || pipe >= USB_MAX_ENDPOINTS)
    break;
    ep = &udc->eps[pipe];

    \
     
     \ /
      Last update: 2016-11-14 03:50    [W:4.047 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site