lkml.org 
[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 182/346] USB: serial: mos7720: fix non-atomic allocation in write path
    3.16.39-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Alexey Khoroshilov <khoroshilov@ispras.ru>

    commit 5a5a1d614287a647b36dff3f40c2b0ceabbc83ec upstream.

    There is an allocation with GFP_KERNEL flag in mos7720_write(),
    while it may be called from interrupt context.

    Follow-up for commit 191252837626 ("USB: kobil_sct: fix non-atomic
    allocation in write path")

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/serial/mos7720.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/serial/mos7720.c
    +++ b/drivers/usb/serial/mos7720.c
    @@ -1239,7 +1239,7 @@ static int mos7720_write(struct tty_stru

    if (urb->transfer_buffer == NULL) {
    urb->transfer_buffer = kmalloc(URB_TRANSFER_BUFFER_SIZE,
    - GFP_KERNEL);
    + GFP_ATOMIC);
    if (!urb->transfer_buffer)
    goto exit;
    }
    \
     
     \ /
      Last update: 2016-11-14 03:06    [W:2.225 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site