lkml.org 
[lkml]   [2016]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task
On 12 November 2016 at 03:46, Rafael J. Wysocki <rafael@kernel.org> wrote:

>> +static void sugov_work(struct kthread_work *work)
>> {
>> - struct sugov_policy *sg_policy = container_of(work, struct sugov_policy, work);
>> + struct sugov_policy *sg_policy =
>> + container_of(work, struct sugov_policy, work);
>
> Why this change?

Mistake ..

>> static struct sugov_policy *sugov_policy_alloc(struct cpufreq_policy *policy)
>> {
>> struct sugov_policy *sg_policy;
>> + struct task_struct *thread;
>> + struct sched_param param = { .sched_priority = 50 };
>
> I'd define a symbol for the 50. It's just one extra line of code ...

Sure.

As I asked in the cover letter, will you be fine if I send the same patch
for ondemand/conservative governors ?

\
 
 \ /
  Last update: 2016-11-12 06:25    [W:0.126 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site