Messages in this thread | | | From | Marek Vasut <> | Subject | Re: [PATCH 1/3] mtd: remove unneeded initializer in mtd_ooblayout_{get, set}_bytes() | Date | Sat, 12 Nov 2016 22:25:38 +0100 |
| |
On 11/09/2016 03:08 AM, Masahiro Yamada wrote: > There is no need to initialize oobregion and section since they will > be filled by mtd_ooblayout_find_region(). > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
> --- > > drivers/mtd/mtdcore.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c > index d46e4ad..cf85f2b 100644 > --- a/drivers/mtd/mtdcore.c > +++ b/drivers/mtd/mtdcore.c > @@ -1274,8 +1274,8 @@ static int mtd_ooblayout_get_bytes(struct mtd_info *mtd, u8 *buf, > int section, > struct mtd_oob_region *oobregion)) > { > - struct mtd_oob_region oobregion = { }; > - int section = 0, ret; > + struct mtd_oob_region oobregion; > + int section, ret; > > ret = mtd_ooblayout_find_region(mtd, start, §ion, > &oobregion, iter); > @@ -1317,8 +1317,8 @@ static int mtd_ooblayout_set_bytes(struct mtd_info *mtd, const u8 *buf, > int section, > struct mtd_oob_region *oobregion)) > { > - struct mtd_oob_region oobregion = { }; > - int section = 0, ret; > + struct mtd_oob_region oobregion; > + int section, ret; > > ret = mtd_ooblayout_find_region(mtd, start, §ion, > &oobregion, iter); >
-- Best regards, Marek Vasut
| |