Messages in this thread | | | Date | Fri, 11 Nov 2016 09:34:37 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH v2 1/3] pinctrl: sunxi: Fix PIN_CONFIG_BIAS_PULL_{DOWN,UP} argument |
| |
On Fri, Nov 11, 2016 at 10:44:53AM +0800, Chen-Yu Tsai wrote: > According to pinconf-generic.h, the argument for > PIN_CONFIG_BIAS_PULL_{DOWN,UP} is non-zero if the bias is enabled > with a pull up/down resistor, zero if it is directly connected > to VDD or ground. > > Since Allwinner hardware uses a weak pull resistor internally, > the argument should be 1. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks! Maxime
-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |