lkml.org 
[lkml]   [2016]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v11 7/7] KVM: x86: virtualize cpuid faulting
From
Date

> On Nov 10, 2016, at 3:40 PM, Kyle Huey <me@kylehuey.com> wrote:
>
> Hardware support for faulting on the cpuid instruction is not required to
> emulate it, because cpuid triggers a VM exit anyways. KVM handles the relevant
> MSRs (MSR_PLATFORM_INFO and MSR_MISC_FEATURES_ENABLE) and upon a
> cpuid-induced VM exit checks the cpuid faulting state and the CPL.
> kvm_require_cpl is even kind enough to inject the GP fault for us.

I think that for consistency you should also revise em_cpuid() of KVM
instruction emulator. Otherwise it may be a potential security
hazard (as far fetched as it currently seems).

Nadav


\
 
 \ /
  Last update: 2016-11-11 22:12    [W:0.160 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site