lkml.org 
[lkml]   [2016]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V4 9/9] PM / OPP: Don't assume platform doesn't have regulators
    Date
    If the regulators aren't set explicitly by the platform, the OPP core
    assumes that the platform doesn't have any regulator and uses the
    clk-only callback.

    If the platform failed to register a regulator with the core, then this
    can turn out to be a dangerous assumption as the OPP core will try to
    change clk without changing regulators.

    Handle that properly by making sure that the DT didn't have any entries
    for supply voltages as well.

    Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
    ---
    V4:
    - s/had/have
    - fix missing rcu_read_unlock()

    drivers/base/power/opp/core.c | 13 +++++++++++++
    1 file changed, 13 insertions(+)

    diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.c
    index 3298fac01bb0..cb33f8b2b56d 100644
    --- a/drivers/base/power/opp/core.c
    +++ b/drivers/base/power/opp/core.c
    @@ -734,7 +734,20 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq)

    /* Only frequency scaling */
    if (!regulators) {
    + unsigned long u_volt = opp->supplies[0].u_volt;
    +
    rcu_read_unlock();
    +
    + /*
    + * DT contained supply ratings? Consider platform failed to set
    + * regulators.
    + */
    + if (unlikely(u_volt)) {
    + dev_err(dev, "%s: Regulator not registered with OPP core\n",
    + __func__);
    + return -EINVAL;
    + }
    +
    return _generic_set_opp_clk_only(dev, clk, old_freq, freq);
    }

    --
    2.7.1.410.g6faf27b
    \
     
     \ /
      Last update: 2016-11-10 06:17    [W:3.418 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site