lkml.org 
[lkml]   [2016]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 21/35] staging: lustre: statahead: lock leaks if statahead file recreated
    Date
    From: Lai Siyao <lai.siyao@intel.com>

    During statahead file may be recreated, though this is rare case,
    current code will leak the lock, this patch will release lock in
    this case.

    Signed-off-by: Lai Siyao <lai.siyao@intel.com>
    Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7232
    Reviewed-on: http://review.whamcloud.com/16841
    Reviewed-by: Fan Yong <fan.yong@intel.com>
    Reviewed-by: John L. Hammond <john.hammond@intel.com>
    Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
    Signed-off-by: James Simmons <jsimmons@infradead.org>
    ---
    drivers/staging/lustre/lustre/llite/statahead.c | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/drivers/staging/lustre/lustre/llite/statahead.c b/drivers/staging/lustre/lustre/llite/statahead.c
    index 0677513..b43955f 100644
    --- a/drivers/staging/lustre/lustre/llite/statahead.c
    +++ b/drivers/staging/lustre/lustre/llite/statahead.c
    @@ -1475,6 +1475,7 @@ static int revalidate_statahead_dentry(struct inode *dir,

    alias = ll_splice_alias(inode, *dentryp);
    if (IS_ERR(alias)) {
    + ll_intent_release(&it);
    rc = PTR_ERR(alias);
    goto out_unplug;
    }
    @@ -1493,6 +1494,7 @@ static int revalidate_statahead_dentry(struct inode *dir,
    *dentryp,
    PFID(ll_inode2fid((*dentryp)->d_inode)),
    PFID(ll_inode2fid(inode)));
    + ll_intent_release(&it);
    rc = -ESTALE;
    goto out_unplug;
    }
    --
    1.7.1
    \
     
     \ /
      Last update: 2016-11-10 18:33    [W:4.172 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site