Messages in this thread Patch in this message | | | Date | Thu, 10 Nov 2016 16:22:41 +0100 | From | Joerg Roedel <> | Subject | Re: [RFC v2 2/8] iommu/iova: fix __alloc_and_insert_iova_range |
| |
On Fri, Nov 04, 2016 at 11:24:00AM +0000, Eric Auger wrote: > Fix the size check within start_pfn and limit_pfn. > > Signed-off-by: Eric Auger <eric.auger@redhat.com> > > --- > > the issue was observed when playing with 1 page iova domain with > higher iova reserved. > --- > drivers/iommu/iova.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/iova.c b/drivers/iommu/iova.c > index e23001b..ee29dbf 100644 > --- a/drivers/iommu/iova.c > +++ b/drivers/iommu/iova.c > @@ -147,7 +147,7 @@ static int __alloc_and_insert_iova_range(struct iova_domain *iovad, > if (!curr) { > if (size_aligned) > pad_size = iova_get_pad_size(size, limit_pfn); > - if ((iovad->start_pfn + size + pad_size) > limit_pfn) { > + if ((iovad->start_pfn + size + pad_size - 1) > limit_pfn) {
A >= check is more readable here.
Joerg
| |