Messages in this thread | | | Date | Fri, 7 Oct 2016 18:25:56 +0200 | From | Benjamin Tissoires <> | Subject | Re: [PATCH] hid-led.c: remove unneccessary underscores |
| |
On Oct 03 2016 or thereabouts, Pavel Machek wrote: > On Mon 2016-10-03 10:16:26, Pavel Machek wrote: > > > > u8 (and friends) can be used directly in kernel sources (not kernel > > headers). > > > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > Zero day bot warned me that this is not quiet correct. > > This would be needed on top. Is there interest in fixed patch?
Having both __ and not __ in the same driver would be a little bit weird. So I'd say we just continue with the existing code. Thanks for the submission BTW!
Cheers, Benjamin
> > diff --git a/drivers/hid/hid-led.c b/drivers/hid/hid-led.c > index cd208ca..be659ca 100644 > --- a/drivers/hid/hid-led.c > +++ b/drivers/hid/hid-led.c > @@ -57,8 +57,8 @@ union delcom_packet { > u8 cmd; > } rx; > struct { > - le16 family_code; > - le16 security_code; > + __le16 family_code; > + __le16 security_code; > u8 fw_version; > } fw; > }; > >
| |