lkml.org 
[lkml]   [2016]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 85/93] USB: serial: cp210x: fix hardware flow-control disable
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>

    commit a377f9e906af4df9071ba8ddba60188cb4013d93 upstream.

    A bug in the CRTSCTS handling caused RTS to alternate between

    CRTSCTS=0 => "RTS is transmit active signal" and
    CRTSCTS=1 => "RTS is used for receive flow control"

    instead of

    CRTSCTS=0 => "RTS is statically active" and
    CRTSCTS=1 => "RTS is used for receive flow control"

    This only happened after first having enabled CRTSCTS.

    Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com>
    Fixes: 39a66b8d22a3 ("[PATCH] USB: CP2101 Add support for flow control")
    [johan: reword commit message ]
    Signed-off-by: Johan Hovold <johan@kernel.org>
    [johan: backport to 4.4 ]
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---

    This is a backport of an upstream fix to v4.4, which should apply too
    earlier stable trees as well.

    Johan


    drivers/usb/serial/cp210x.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/serial/cp210x.c
    +++ b/drivers/usb/serial/cp210x.c
    @@ -784,7 +784,7 @@ static void cp210x_set_termios(struct tt
    } else {
    modem_ctl[0] &= ~0x7B;
    modem_ctl[0] |= 0x01;
    - modem_ctl[1] |= 0x40;
    + modem_ctl[1] = 0x40;
    dev_dbg(dev, "%s - flow control = NONE\n", __func__);
    }


    \
     
     \ /
      Last update: 2016-10-06 11:04    [W:2.975 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site