Messages in this thread | | | Date | Thu, 6 Oct 2016 17:05:43 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 2/3] perf, tools: Handle completion of upper case events |
| |
Em Thu, Oct 06, 2016 at 12:23:26PM -0700, Andi Kleen escreveu: > From: Andi Kleen <ak@linux.intel.com> > > Vendor events are often specified in upper case. perf list outputs them > in lower case. Handle this case in perf-completion.sh so that > completion on the upper case events still works.
Thanks, applied.
> v2: Use locale aware check for upper case > v3: Use perf list json > Signed-off-by: Andi Kleen <ak@linux.intel.com> > --- > tools/perf/perf-completion.sh | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh > index 3ba80b2359cc..3b5a258a4b7b 100644 > --- a/tools/perf/perf-completion.sh > +++ b/tools/perf/perf-completion.sh > @@ -161,7 +161,11 @@ __perf_main () > # List possible events for -e option > elif [[ $prev == @("-e"|"--event") && > $prev_skip_opts == @(record|stat|top) ]]; then > - evts=$($cmd list --raw-dump) > + # handle upper case events > + case "$cur" in > + [[:upper:]]*) evts=$($cmd list --raw-dump json | tr a-z A-Z) ;; > + *) evts=$($cmd list --raw-dump) ;; > + esac > __perfcomp_colon "$evts" "$cur" > else > # List subcommands for perf commands > -- > 2.5.5
| |