lkml.org 
[lkml]   [2016]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 12/54] md/raid1: Use kcalloc() in setup_conf()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 4 Oct 2016 15:30:28 +0200

    * A multiplication for the size determination of a memory allocation
    indicated that an array data structure should be processed.
    Thus use the corresponding function "kcalloc".

    * Replace the specification of a data structure by a pointer dereference
    to make the corresponding size determination a bit safer according to
    the Linux coding style convention.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/md/raid1.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
    index e75ae87..5969711 100644
    --- a/drivers/md/raid1.c
    +++ b/drivers/md/raid1.c
    @@ -2781,9 +2781,9 @@ static struct r1conf *setup_conf(struct mddev *mddev)
    if (!conf)
    goto abort;

    - conf->mirrors = kzalloc(sizeof(struct raid1_info)
    - * mddev->raid_disks * 2,
    - GFP_KERNEL);
    + conf->mirrors = kcalloc(mddev->raid_disks * 2,
    + sizeof(*conf->mirrors),
    + GFP_KERNEL);
    if (!conf->mirrors)
    goto abort;

    --
    2.10.1
    \
     
     \ /
      Last update: 2016-10-06 11:08    [W:3.530 / U:0.292 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site