lkml.org 
[lkml]   [2016]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] mm, oom: do not rely on TIF_MEMDIE for exit_oom_victim
On Tue 04-10-16 18:21:14, Oleg Nesterov wrote:
[...]
> so this can't detect the multi-threaded group exit, and ...
>
> > list_for_each_entry_safe(p, n, &dead, ptrace_entry) {
> > list_del_init(&p->ptrace_entry);
> > - release_task(p);
> > + if (release_task(p) && p == tsk)
> > + last = true;
>
> this can only happen if this process auto-reaps itself. Not to mention
> that exit_notify() will never return true if traced.
>
> No, this doesn't look right.

You are right. I should have noticed that. Especially when I was hunting
the strace hang bug. I started to have a bad feeling about this patch
but for some reason I just didn't put all the pieces together.

So the patch is completely b0rked. Back to drawing board and start
again. Oh well...

Anyway thanks and sorry to waste your time.

--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2016-10-05 11:38    [W:0.041 / U:1.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site