Messages in this thread | | | From | 岩松信洋 / IWAMATSU,NOBUHIRO <> | Subject | RE: [PATCH v2 5/5] selftests/pstore: add testcases for multiple pmsg instances | Date | Wed, 5 Oct 2016 04:14:14 +0000 |
| |
Hi,
> -----Original Message----- > From: keescook@google.com [mailto:keescook@google.com] On Behalf Of Kees > Cook > Sent: Friday, September 09, 2016 6:56 AM > To: 岩松信洋 / IWAMATSU,NOBUHIRO > Cc: Anton Vorontsov; Colin Cross; Tony Luck; LKML; Hiraku Toyooka; Mark > Salyzyn; 阿口誠司 / AGUCHI,SEIJI; Shuah Khan > Subject: Re: [PATCH v2 5/5] selftests/pstore: add testcases for multiple > pmsg instances > > On Sun, Jul 24, 2016 at 8:56 PM, Nobuhiro Iwamatsu > <nobuhiro.iwamatsu.kw@hitachi.com> wrote: > > From: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> > > > > To test multiple pmsg, we should check that /dev/pmsg[N] (N > 0) is > > available. After reboot, we should check that pmsg-[backend]-[N] which > > keeps content is detected even if pmsg-[backend]-[N-M] (0 < M <= N) > > doesn't exist due to lack of contents. > > > > So this adds the following testcases. > > - pstore_tests > > - Write unique string to the last /dev/pmsgN > > - pstore_post_reboot_tests > > - Check the last pmsg area is detected > > > > Signed-off-by: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com> > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.kw@hitachi.com> > > Cc: Mark Salyzyn <salyzyn@android.com> > > Cc: Seiji Aguchi <seiji.aguchi.tr@hitachi.com> > > Cc: Shuah Khan <shuahkh@osg.samsung.com> > > --- > > tools/testing/selftests/pstore/common_tests | 21 > +++++++++++++++-- > > .../selftests/pstore/pstore_post_reboot_tests | 27 > ++++++++++++---------- > > tools/testing/selftests/pstore/pstore_tests | 16 > ++++++++++--- > > 3 files changed, 47 insertions(+), 17 deletions(-) > > > > diff --git a/tools/testing/selftests/pstore/common_tests > > b/tools/testing/selftests/pstore/common_tests > > index 3ea64d7..566a25d 100755 > > --- a/tools/testing/selftests/pstore/common_tests > > +++ b/tools/testing/selftests/pstore/common_tests
<snip>
> > +last_devpmsg=`ls -v /dev/pmsg* | tail -n1` prlog -n "Writing unique > > +string to the last /dev/pmsgN " > > +if [ "$last_devpmsg" = "/dev/pmsg0" ]; then > > + prlog "... No multiple /dev/pmsg* exists. We skip this testcase." > > +else > > + prlog -n "(${last_devpmsg}) ... " > > + echo "${TEST_STRING_PATTERN}""$UUID" > ${last_devpmsg} > > + show_result $? > > + > > Blank line here can be dropped. > > > +fi > > + > > exit $rc > > -- > > 2.8.1 > > > > > > Otherwise, this looks good. Thanks! >
OK, I will fix these. And thanks again for review this patch series.
> -Kees > > -- > Kees Cook > Nexus Security
Best regards, Nobuhiro
| |