lkml.org 
[lkml]   [2016]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:sched/urgent] Revert "sched/core: Do not use smp_processor_id() with preempt enabled in smpboot_thread_fn()"
On Tue, 4 Oct 2016, tip-bot for Ingo Molnar wrote:
> The original change widens a preempt-off section, to avoid a seemingly unsafe
> smp_processor_id() use.
>
> During review I overlooked two facts:
>
> - The code to calls a non-trivial function callback:
>
> ht->park(td->cpu);
>
> ... which might (and does occasionally) sleep, triggering the warning.
>
> - More importantly, as pointed out by Peter Zijlstra, using
> smp_processor_id() in that context is safe, if it's done from
> a kernel thread that is pinned to a single CPU - which is the
> case here.
>
> So revert to the original code that enables preemption sooner.
>
> Reported-by: kernel test robot <xiaolong.ye@intel.com>
> Acked-by: Peter Zijlstra <peterz@infradead.org>

Acked-by: Thomas Gleixner <tglx@linutronix.de>

\
 
 \ /
  Last update: 2016-10-04 10:25    [W:0.078 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site