lkml.org 
[lkml]   [2016]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] staging: iio: cdc: ad7746: add additional config defines
On Mon, Oct 31, 2016 at 03:49:01PM +0800, Eva Rachel Retuya wrote:
> On Sun, Oct 30, 2016 at 06:49:00PM +0000, Jonathan Cameron wrote:
> > On 30/10/16 17:46, Lars-Peter Clausen wrote:
> > > On 10/30/2016 06:41 PM, Jonathan Cameron wrote:
> > >> On 28/10/16 09:26, Eva Rachel Retuya wrote:
> > >>> Introduce defines for shifting and mask under the config register for
> > >>> better readability. Also, introduce helper variables for index
> > >>> calculation.
> > >>>
> > >>> Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
> > >> Looks good to me.
> > >>
> > >> Lars could you sanity check this one as well?
> > >
> > > Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> > There was a bit of fun applying this. Eva, can you check I didn't mess it
> > up?
>
> It looks fine to me. Thanks!
>

Have to retract that statement, I rebased and went through the merge
conflict. Extra whitespace can be seen after the statement in line 644:
*val = ad7746_cap_filter_rate_table[idx][0];

What to do?
Eva

> >
> > Applied to the togreg branch of iio.git. Initially pushed out as testing
> > for the autobuilders to play with it. (and this time I remembered to actually
> > do the push!)
> >
> > thanks,
> >
> > Jonathan
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > >
> >

\
 
 \ /
  Last update: 2016-10-31 09:06    [W:0.311 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site