Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH] cxl: Fix error handling | Date | Mon, 31 Oct 2016 20:50:12 +1100 |
| |
Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes:
> On 31/10/16 08:34, Christophe JAILLET wrote: >> 'cxl_dev_context_init()' returns an error pointer in case of error, not >> NULL. So test it with IS_ERR. >> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> > >> --- >> un-compiled because I don't have the required cross build environment. > > Builds fine here. > > In future, you might want to bundle all 3 of your patches either into 1 > patch (while they are changes which can be done separately, it's all > fixes to one type of problem in relation to one function, so personally > I'm okay with that) or send it as a series, so that it's clear to > everyone that they're all related fixes.
> Additionally, having the same patch subject line for two patches sent in > short succession is a bit confusing - in future, try and avoid that.
Yeah. I actually assumed it was two versions of the same patch.
cheers
| |