lkml.org 
[lkml]   [2016]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/3] NCR5380: Check for chip presence in NCR5380_init()
    Date
    Read back MODE_REG after writing it in NCR5380_init() to check if the
    chip is really there.

    This prevents hang when incorrect I/O address was specified by user.

    Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
    ---
    drivers/scsi/NCR5380.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
    index 01c0027..ce3156d 100644
    --- a/drivers/scsi/NCR5380.c
    +++ b/drivers/scsi/NCR5380.c
    @@ -495,6 +495,11 @@ static int NCR5380_init(struct Scsi_Host *instance, int flags)

    NCR5380_write(INITIATOR_COMMAND_REG, ICR_BASE);
    NCR5380_write(MODE_REG, MR_BASE);
    + /* check if the chip is really there */
    + if (NCR5380_read(MODE_REG) != MR_BASE) {
    + NCR5380_exit(instance);
    + return -ENODEV;
    + }
    NCR5380_write(TARGET_COMMAND_REG, 0);
    NCR5380_write(SELECT_ENABLE_REG, 0);

    --
    Ondrej Zary
    \
     
     \ /
      Last update: 2016-10-30 23:43    [W:3.638 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site