lkml.org 
[lkml]   [2016]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] tpm: don't destroy chip device prematurely
    On Mon, Oct 03, 2016 at 07:05:48AM +0000, Winkler, Tomas wrote:

    > > This patch is wrong, I though the comments were clear. All entry points to find
    > > the device must be deleted before we commit to shutting down the device.
    > >
    > > You need to figure out some other way to solve your problem.
    >
    > Please be more specific regarding flows you think will be wrong with
    > this patch, you must agree that the current code is broken even w/o
    > runtime pm.

    No, I don't agree. Accessing dev->name is OK after the device_del.

    What devicde_del does is fence off all sorts of ways to access the
    device, eg sysfs files, bus registrations, etc, etc. That absolutely
    must be done before calling tpm_suspend.

    Jason

    \
     
     \ /
      Last update: 2016-10-03 18:01    [W:4.059 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site