Messages in this thread | | | Subject | Re: [PATCH v2 2/2] KVM: s390: Use memdup_user() rather than duplicating code | From | SF Markus Elfring <> | Date | Mon, 3 Oct 2016 14:28:24 +0200 |
| |
>> - if (!bp_data) { >> - ret = -ENOMEM; >> - goto error; >> - } >> - >> - if (copy_from_user(bp_data, >> - dbg->arch.hw_bp, >> - sizeof(*bp_data) * dbg->arch.nr_hw_bp)) { >> - ret = -EFAULT; >> - goto error; >> - } >> + bp_data = memdup_user(dbg->arch.hw_bp, >> + sizeof(*bp_data) * dbg->arch.nr_hw_bp); > > ... while this would continue silently,
How do you think about to explain this information a bit more?
> and corrupt memory.
I wonder about this conclusion at the moment.
Did you notice the check "IS_ERR(bp_data)" and the corresponding reaction in this update suggestion?
How does your feedback fit to the tag "Acked-by: Cornelia Huck" from 2016-08-25?
Regards, Markus
| |