lkml.org 
[lkml]   [2016]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf probe: check if *ptr2 is zero and not ptr2
Em Mon, Oct 03, 2016 at 11:34:31AM +0100, Colin King escreveu:
> From: Colin Ian King <colin.king@canonical.com>
>
> Static anaylsis with cppcheck detected an incorrect comparison:
> [tools/perf/util/probe-event.c:216]: (warning) Char literal compared with
> pointer 'ptr2'. Did you intend to dereference it?

What tool was used for that?

- Arnaldo

> Dereference ptr2 for the comparison to fix this.
>
> Fixes: 35726d3a4ca9 ("perf probe: Fix to cut off incompatible chars from group name")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> tools/perf/util/probe-event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index fcfbef0..d281ae2 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -213,7 +213,7 @@ static int convert_exec_to_group(const char *exec, char **result)
> goto out;
> }
>
> - for (ptr2 = ptr1; ptr2 != '\0'; ptr2++) {
> + for (ptr2 = ptr1; *ptr2 != '\0'; ptr2++) {
> if (!isalnum(*ptr2) && *ptr2 != '_') {
> *ptr2 = '\0';
> break;
> --
> 2.9.3

\
 
 \ /
  Last update: 2016-10-03 13:19    [W:0.059 / U:2.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site