lkml.org 
[lkml]   [2016]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.8 043/125] coresight: Remove erroneous dma_free_coherent in tmc_probe
    Date
    4.8-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Suzuki K Poulose <suzuki.poulose@arm.com>

    commit 481e46fe7a88557b66330cbb047b25cc13eff4b9 upstream.

    commit de5461970b3e9e194 ("coresight: tmc: allocating memory when needed")
    removed the static allocation of buffer for the trace data in ETR mode in
    tmc_probe. However it failed to remove the "devm_free_coherent" in
    tmc_probe when the probe fails due to other reasons. This patch gets
    rid of the incorrect dma_free_coherent() call.

    Fixes: commit de5461970b3e9e194 ("coresight: tmc: allocating memory when needed")
    Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
    Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/hwtracing/coresight/coresight-tmc.c | 3 ---
    1 file changed, 3 deletions(-)

    --- a/drivers/hwtracing/coresight/coresight-tmc.c
    +++ b/drivers/hwtracing/coresight/coresight-tmc.c
    @@ -388,9 +388,6 @@ static int tmc_probe(struct amba_device
    err_misc_register:
    coresight_unregister(drvdata->csdev);
    err_devm_kzalloc:
    - if (drvdata->config_type == TMC_CONFIG_TYPE_ETR)
    - dma_free_coherent(dev, drvdata->size,
    - drvdata->vaddr, drvdata->paddr);
    return ret;
    }


    \
     
     \ /
      Last update: 2016-10-29 16:13    [W:4.098 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site