Messages in this thread | | | Date | Fri, 28 Oct 2016 09:34:02 +0200 | From | Daniel Vetter <> | Subject | Re: [PATCH v6 2/6] drm/imx: use drm_atomic_set_fence_for_plane() to set the fence |
| |
On Thu, Oct 27, 2016 at 05:37:07PM -0200, Gustavo Padovan wrote: > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > > drm_atomic_set_fence_for_plane() is smart and won't overwrite > plane_state->fence if the user already set an explicit fence there. > > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Process nit: Please make sure you Cc: driver maintainers for driver patches. Best done by putting the Cc: into the patch, then you never forget ;-)
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/imx/imx-drm-core.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > index 98df09c..07fe955 100644 > --- a/drivers/gpu/drm/imx/imx-drm-core.c > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > @@ -158,6 +158,7 @@ static int imx_drm_atomic_commit(struct drm_device *dev, > struct drm_plane_state *plane_state; > struct drm_plane *plane; > struct dma_buf *dma_buf; > + struct dma_fence *fence; > int i; > > /* > @@ -170,8 +171,9 @@ static int imx_drm_atomic_commit(struct drm_device *dev, > 0)->base.dma_buf; > if (!dma_buf) > continue; > - plane_state->fence = > - reservation_object_get_excl_rcu(dma_buf->resv); > + fence = reservation_object_get_excl_rcu(dma_buf->resv); > + > + drm_atomic_set_fence_for_plane(plane_state, fence); > } > } > > -- > 2.5.5 >
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
| |