[lkml]   [2016]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 3/3] ovl: redirect on rename-dir
On Tue, Oct 25, 2016 at 09:34:47AM +0200, Miklos Szeredi wrote:
> Current code returns EXDEV when a directory would need to be copied up to
> move. We could copy up the directory tree in this case, but there's
> another solution: point to old lower directory from moved upper directory.
> This is achieved with a "trusted.overlay.redirect" xattr storing the path
> relative to the root of the overlay. After such attribute has been set,
> the directory can be moved without further actions required.
> This is a backward incompatible feature, old kernels won't be able to
> correctly mount an overlay containing redirected directories.

> + err = vfs_path_lookup(lowerpath.dentry, lowerpath.mnt,
> + redirect, 0, &thispath);
> +
> + if (err) {
> + if (err == -ENOENT || err == -ENAMETOOLONG)
> + this = NULL;
> + } else {
> + this = thispath.dentry;
> + mntput(thispath.mnt);
> + if (!this->d_inode) {
> + dput(this);
> + this = NULL;
> + } else if (ovl_dentry_weird(this)) {
> + dput(this);
> + err = -EREMOTE;
> + }
> + }

I'm not happy with that one - you are relying upon the fairly subtle
assertions here.
1) Had lowerpath.mnt *not* been a privately cloned one with nothing
mounted on it, you would've been screwed.
2) Had that thing contained a "jumper" symlink (a-la procfs ones),
you would've been screwed. Currently only procfs has those, and it would've
been rejected before getting there, but this is brittle and non-obvious.
3) Any automount point in there (nfs4 referrals, etc.) can
break the assumption that nothing could've been mounted on it. And _that_
might have not been stepped onto; back when the path had been stored, there'd
been no automount point at all, so we have avoided ovl_dentry_weird() rejects,
and by now nothing on the path had been visited yet, so ovl_dentry_weird()
didn't have a chance to trigger. Note that calling it on the last dentry
is no good - we might have crossed the automount point in the middle of that
path, so this last dentry might be nice and shiny - and on another filesystem.
So unlike (1) and (2) it's not just a fishy-looking thing that happens to
work for non-local reasons; AFAICS, it's actually a bug.

I'm not sure if vfs_path_lookup() is the right tool here. It might be
usable for making such a tool, but as it is you are setting one hell of
a trap for yourself...

It might be made to work, if we figure out the right semantics for disabling
symlinks on per-vfsmount basis (and no, the posted nolinks patches are not
it) and mark these private clones with that and with similar "disable
automount traversals" flag (again, needs the right semantics; the area is
convoluted as it is). But in that case I would strongly recommend adding
an exported wrapper around vfs_path_lookup() that would verify that these
flags *are* set.

 \ /
  Last update: 2016-10-28 18:16    [W:0.128 / U:35.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site