lkml.org 
[lkml]   [2016]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 3/4] input: Deprecate real timestamps beyond year 2106
On Fri, Oct 28, 2016 at 5:43 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Monday, October 17, 2016 8:27:32 PM CEST Deepa Dinamani wrote:
>> @@ -55,24 +60,24 @@ struct ff_effect_compat {
>>
>> static inline size_t input_event_size(void)
>> {
>> - return (in_compat_syscall() && !COMPAT_USE_64BIT_TIME) ?
>> - sizeof(struct input_event_compat) : sizeof(struct input_event);
>> + return in_compat_syscall() ? sizeof(struct raw_input_event_compat) :
>> + sizeof(struct raw_input_event);
>> }
>
> I think the COMPAT_USE_64BIT_TIME check has to stay here,
> it's needed for x32 mode on x86-64.

There is no time_t anymore in the raw_input_event structure.
The struct uses __kernel_ulong_t type.
This should take care of x32 support.

From this cover letter:
https://www.spinics.net/lists/linux-arch/msg16356.html

I see that that the __kernel types were introduced to address the ABI
issues for x32.

-Deepa

\
 
 \ /
  Last update: 2016-10-28 17:20    [W:0.261 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site