lkml.org 
[lkml]   [2016]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 2/3] sched: Introduce Window-Assisted CPU utilization Tracking
On Fri, Oct 28, 2016 at 12:10:41AM -0700, Vikram Mulukutla wrote:
> +void walt_finish_migrate(struct task_struct *p, struct rq *dest_rq, bool locked)
> +{
> + u64 wallclock;
> + unsigned long flags;
> +
> + if (!p->on_rq && p->state != TASK_WAKING)
> + return;
> +
> + if (locked == false)
> + raw_spin_lock_irqsave(&dest_rq->lock, flags);
> +

> +
> + if (locked == false)
> + raw_spin_unlock_irqrestore(&dest_rq->lock, flags);
> +}
> +
> +void walt_prepare_migrate(struct task_struct *p, struct rq *src_rq, bool locked)
> +{
> + u64 wallclock;
> + unsigned long flags;
> +
> + if (!p->on_rq && p->state != TASK_WAKING)
> + return;
> +
> + if (locked == false)
> + raw_spin_lock_irqsave(&src_rq->lock, flags);
> +

> +
> + if (locked == false)
> + raw_spin_unlock_irqrestore(&src_rq->lock, flags);
> +}

Seriously bad style that. Please, less bonghits before writing code.

\
 
 \ /
  Last update: 2016-10-28 09:46    [W:0.093 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site