Messages in this thread | | | Subject | Re: [RFC PATCH 13/13] of: Remove unused variable overlay_symbols | From | Frank Rowand <> | Date | Thu, 27 Oct 2016 09:57:56 -0700 |
| |
On 10/27/16 09:53, Frank Rowand wrote: > On 10/27/16 09:27, Frank Rowand wrote: >> On 10/27/16 07:41, Pantelis Antoniou wrote: >>> Hi Frank, >>> >>> >>>> On Oct 25, 2016, at 23:59 , frowand.list@gmail.com wrote: >>>> >>>> From: Frank Rowand <frank.rowand@am.sony.com> >>>> >>>> This unused variable is a reminder that symbols in overlays are >>>> not available to subsequent overlays. If such a feature is >>>> desired then there are several ways it could be implemented. >>>> >>> >>> Please don’t apply that. There’s a patch that actually imports >>> the symbol table from overlays that subsequent operations >>> work. >>> >>> Please see: >>> >>> https://patchwork.kernel.org/patch/9104701/ >> >> Thanks for the pointer! When the import symbols patch is applied >> then the comment in my patch header becomes incorrect. I will >> change the patch comment to act is if the import symbols patch >> is in place. >> >> But the node pointer that my patch removes is still not used >> for anything, even if the import symbols patch is applied. >> >> Am I missing something? > > I was missing a later patch in the symbol import patch set that > updated resolver.c to use the imported symbols. I'll go look > at that.
Crap. I misread the file name in the patch that I thought was updating resolver.c. It was actually overlay.c. So I am back to my question of:
Am I missing something?
| |