lkml.org 
[lkml]   [2016]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] can: fix warning in bcm_connect/proc_register
On Thu, Oct 27, 2016 at 1:45 AM, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> On 10/24/2016 10:17 PM, Cong Wang wrote:
>> On Mon, Oct 24, 2016 at 1:10 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>>> On Mon, Oct 24, 2016 at 12:11 PM, Oliver Hartkopp
>>> <socketcan@hartkopp.net> wrote:
>>>> if (proc_dir) {
>>>> /* unique socket address as filename */
>>>> sprintf(bo->procname, "%lu", sock_i_ino(sk));
>>>> bo->bcm_proc_read = proc_create_data(bo->procname, 0644,
>>>> proc_dir,
>>>> &bcm_proc_fops, sk);
>>>> + if (!bo->bcm_proc_read) {
>>>> + ret = -ENOMEM;
>>>> + goto fail;
>>>> + }
>>>
>>> Well, I meant we need to call proc_create_data() once per socket,
>>> so we need a check before proc_create_data() too.
>>
>> Hmm, bo->bound should guarantee it, so never mind, your patch
>> looks fine.
>
> Can I add your Acked-by?

Of course.

Acked-by: Cong Wang <xiyou.wangcong@gmail.com>

Thanks.

\
 
 \ /
  Last update: 2016-10-27 18:29    [W:0.065 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site