lkml.org 
[lkml]   [2016]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.8 110/140] irqchip/gicv3: Handle loop timeout proper
    Date
    4.8-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit d102eb5c1ac5e6743b1c6d145c06a25d98ad1375 upstream.

    The timeout loop terminates when the loop count is zero, but the decrement
    of the count variable is post check. So count is -1 when we check for the
    timeout and therefor the error message is supressed.

    Change it to predecrement, so the error message is emitted.

    [ tglx: Massaged changelog ]

    Fixes: a2c225101234 ("irqchip: gic-v3: Refactor gic_enable_redist to support both enabling and disabling")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Sudeep Holla <sudeep.holla@arm.com>
    Cc: Marc Zyngier <marc.zyngier@arm.com>
    Cc: kernel-janitors@vger.kernel.org
    Cc: Jason Cooper <jason@lakedaemon.net>
    Link: http://lkml.kernel.org/r/20161014072534.GA15168@mwanda
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/irqchip/irq-gic-v3.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/irqchip/irq-gic-v3.c
    +++ b/drivers/irqchip/irq-gic-v3.c
    @@ -153,7 +153,7 @@ static void gic_enable_redist(bool enabl
    return; /* No PM support in this redistributor */
    }

    - while (count--) {
    + while (--count) {
    val = readl_relaxed(rbase + GICR_WAKER);
    if (enable ^ (bool)(val & GICR_WAKER_ChildrenAsleep))
    break;

    \
     
     \ /
      Last update: 2016-10-26 15:15    [W:3.071 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site