Messages in this thread | | | Date | Wed, 26 Oct 2016 14:38:55 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH] mfd: tps65217: Drop call to irq_set_parent() |
| |
On Wed, 26 Oct 2016, Lee Jones wrote: > On Fri, 14 Oct 2016, Guenter Roeck wrote: > > > The call to irq_set_parent() causes the following build error if tps65217 > > is built as module. > > > > ERROR: ".irq_set_parent" [drivers/mfd/tps65217.ko] undefined! > > > > The problem was introduced with commit 6556bdacf646f ("mfd: tps65217: Add > > support for IRQs"). > > > > The author states: "I have added irq_set_parent() similarly as in > > drivers/base/regmap/regmap-irq.c. But to be honest I am not sure what it > > really does in case of tps65217." > > > > So let's drop it. > > > > Fixes: 6556bdacf646f ("mfd: tps65217: Add support for IRQs") > > Cc: Marcin Niestroj <m.niestroj@grinn-global.com> > > Cc: Arnd Bergmann <arnd@arndb.de> > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > > --- > > drivers/mfd/tps65217.c | 1 - > > 1 file changed, 1 deletion(-) > > This has been fixed now.
It was not fixed. The export was a work around as everyone was bitching about the build robots failing forever.
So if the irq_set_parent() call is not required for functionality of the driver then it should not be there in the first place.
Thanks,
tglx
| |