lkml.org 
[lkml]   [2016]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.8 127/140] mmc: rtsx_usb_sdmmc: Avoid keeping the device runtime resumed when unused
    Date
    4.8-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ulf Hansson <ulf.hansson@linaro.org>

    commit 31cf742f515c275d22843c4c756e048d2b6d716c upstream.

    The rtsx_usb_sdmmc driver may bail out in its ->set_ios() callback when no
    SD card is inserted. This is wrong, as it could cause the device to remain
    runtime resumed when it's unused. Fix this behaviour.

    Tested-by: Ritesh Raj Sarraf <rrs@researchut.com>
    Cc: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mmc/host/rtsx_usb_sdmmc.c | 5 -----
    1 file changed, 5 deletions(-)

    --- a/drivers/mmc/host/rtsx_usb_sdmmc.c
    +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c
    @@ -1138,11 +1138,6 @@ static void sdmmc_set_ios(struct mmc_hos
    dev_dbg(sdmmc_dev(host), "%s\n", __func__);
    mutex_lock(&ucr->dev_mutex);

    - if (rtsx_usb_card_exclusive_check(ucr, RTSX_USB_SD_CARD)) {
    - mutex_unlock(&ucr->dev_mutex);
    - return;
    - }
    -
    sd_set_power_mode(host, ios->power_mode);
    sd_set_bus_width(host, ios->bus_width);
    sd_set_timing(host, ios->timing, &host->ddr_mode);

    \
     
     \ /
      Last update: 2016-10-26 14:29    [W:4.122 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site