lkml.org 
[lkml]   [2016]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] kernel/smp: Make the SMP boot message common on all arches
Date
Borislav Petkov <bp@suse.de> writes:
> On Thu, Oct 13, 2016 at 07:55:19PM +1100, Michael Ellerman wrote:
>> @@ -564,8 +560,11 @@ void __init smp_init(void)
>> cpu_up(cpu);
>> }
>>
>> + num_nodes = num_online_nodes();
>> + pr_info("smp: Brought up %d node%s, %d CPUs\n",
>> + num_nodes, (num_nodes > 1 ? "s" : ""), num_online_cpus());
>
> Please define pr_fmt for this file so that pr_info adds the prefix
> automatically. I guess
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> at the top, before all the include directives should suffice.

Sure thing.

> Other than that, for both patches:
>
> Reviewed-by: Borislav Petkov <bp@suse.de>

Thanks, v2 coming soon.

cheers

\
 
 \ /
  Last update: 2016-10-26 07:33    [W:0.514 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site