[lkml]   [2016]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 11/14] staging: fsl-mc: message cleanup
On Mon, Oct 17, 2016 at 01:43:39PM -0500, Stuart Yoder wrote:
> Cleanup and clarify messages
> -use "fsl-mc" prefix for all messages that don't come from dev_*
> functions

Nope, please use the proper pr_fmt() #define at the top of the file,
that way you don't have to put the string into all pr_* calls.

> -remove unnecessary verbosity to make things clearer
> -use explicit __func__ arguments to clarify some error messages
> -improve misc wording for clarity

That's alot of different things. Again, if you have to list the
different things you do in a patch, that means you should break it up
into smaller ones. Yes, this is a "tiny" patch, but I can't take it
because of the above problem, while if you had broken it up into smaller
ones, I could have taken all but the pr_* changes :(


greg k-h

 \ /
  Last update: 2016-10-25 09:48    [W:1.165 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site