Messages in this thread Patch in this message | | | From | Paul Bolle <> | Subject | [PATCH 1/2] x86: use stdout if insn decoder test is successful | Date | Tue, 25 Oct 2016 22:56:04 +0200 |
| |
If the instruction decoder test ran successful it prints a message like this to stderr: Succeed: decoded and checked 1767380 instructions
But, as described in "console mode programming user interface guidelines version 101" which doesn't exist, programs should use stderr for errors or warnings. We're told about a successful run here, so the instruction decoder test should use stdout.
Let's fix the typo too, while we're at it.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- The joke about the guidelines is shamelessly copied from commit 55a6e622e66a ("arch/x86/tools/insn_sanity.c: Identify source of messages"). Let's hope Andrew doesn't mind!
arch/x86/tools/test_get_len.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/tools/test_get_len.c b/arch/x86/tools/test_get_len.c index 56f04db0c9c0..ecf31e0358c8 100644 --- a/arch/x86/tools/test_get_len.c +++ b/arch/x86/tools/test_get_len.c @@ -167,7 +167,7 @@ int main(int argc, char **argv) fprintf(stderr, "Warning: decoded and checked %d" " instructions with %d warnings\n", insns, warnings); else - fprintf(stderr, "Succeed: decoded and checked %d" + fprintf(stdout, "Success: decoded and checked %d" " instructions\n", insns); return 0; } -- 2.7.4
| |