Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 3/3] usb: dwc3: host: Do not use dma_coerce_mask_and_coherent | Date | Tue, 25 Oct 2016 22:27:37 +0200 |
| |
On Tuesday, October 25, 2016 4:26:28 PM CEST Sriram Dash wrote: > Do not use dma_coerce_mask_and_coherent for hcd. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
The patch is good, but please follow the usual rules for submitting someone else's patch:
- As the first line, have "From: Arnd Bergmann <arnd@arndb.de>". "git format-patch" adds this automatically if you pass that address as the "--author" argument to "git commit".
- Add you "Signed-off-by" line at below mine (or any other lines)
I would also suggest a more elaborate changelog text, the free-form text should explain why something is done, rather than repeat the subject:
| The dma mask is correctly set up by the DT probe function, no | need to override it any more.
Arnd
| |