lkml.org 
[lkml]   [2016]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] [v2] staging: iio: ad5933: avoid uninitialized variable in error case
From
Date
On 25/10/16 18:00, Lars-Peter Clausen wrote:
> On 10/25/2016 06:57 PM, Jonathan Cameron wrote:
>> On 24/10/16 16:22, Arnd Bergmann wrote:
>>> The ad5933_i2c_read function returns an error code to indicate
>>> whether it could read data or not. However ad5933_work() ignores
>>> this return code and just accesses the data unconditionally,
>>> which gets detected by gcc as a possible bug:
>>>
>>> drivers/staging/iio/impedance-analyzer/ad5933.c: In function 'ad5933_work':
>>> drivers/staging/iio/impedance-analyzer/ad5933.c:649:16: warning: 'status' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>>
>>> This adds minimal error handling so we only evaluate the
>>> data if it was correctly read.
>>>
>>> Link: https://patchwork.kernel.org/patch/8110281/
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Looks good to me.
>>
>> Lars?
>>
>
> Looks good, thanks.
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the fixes-togreg branch of iio.git and marked for stable.

thanks,

Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

\
 
 \ /
  Last update: 2016-10-25 19:32    [W:0.041 / U:2.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site