[lkml]   [2016]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH/RFT v2 11/17] USB: OHCI: make ohci-da8xx a separate driver
On 10/25/2016 02:39 AM, Axel Haslam wrote:
> On Tue, Oct 25, 2016 at 2:38 AM, David Lechner <> wrote:
>> On 10/24/2016 11:46 AM, wrote:
>>> -#error "This file is DA8xx bus glue. Define CONFIG_ARCH_DAVINCI_DA8XX."
>>> -#endif
>>> +#include "ohci.h"
>>> +
>>> +#define DRIVER_DESC "OHCI DA8XX driver"
>>> +
>>> +static const char hcd_name[] = "ohci-da8xx";
>> why static const char instead of #define? This is only used one time in a
>> pr_info, so it seems kind of pointless anyway.
> Other drivers are using static const for the same variable.
> i think static const is preferred over #define because #define doet give a type.
> If you dont mind ill keep it static const.

If this string was used in this file more than one place, I would agree
with you, but currently it is only used as the argument of a pr_info().
The string "ohci-da8xx" could just be included in the fmt string instead
of using "%s".

 \ /
  Last update: 2016-10-25 18:13    [W:0.080 / U:6.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site