Messages in this thread | | | Subject | Re: linux.git: printk() problem | From | Joe Perches <> | Date | Mon, 24 Oct 2016 21:13:47 -0700 |
| |
On Tue, 2016-10-25 at 13:06 +0900, Sergey Senozhatsky wrote: > so how about skipping mod_timer in deferred_cont_flush() and just > cont_flush() when we are in oops? here is probably one more thing we > need to "fix" first. oops_in_progress is unreliable. x86 oops_end() > does bust_spinlocks(0) before it calls panic(). panic() increments > oops_in_progress but decrements it back to 0 (bust_spinlocks(0)) before > it does console_flush_on_panic(). so there is (almost) no way > console_flush_on_panic() can see oops_in_progress != 0.
I think Linus' insistence on not requiring EOL/newline is misguided. It'd be simpler to avoid the flushes and have a require EOL/newline.
| |