Messages in this thread |  | | From | Andrey Konovalov <> | Date | Tue, 25 Oct 2016 14:12:57 +0200 | Subject | Re: [PATCH] can: fix warning in bcm_connect/proc_register |
| |
Hi Oliver,
I can confirm that your patch fixes the warnings for me.
Tested-by: Andrey Konovalov <andreyknvl@google.com>
On Mon, Oct 24, 2016 at 10:17 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote: > On Mon, Oct 24, 2016 at 1:10 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote: >> On Mon, Oct 24, 2016 at 12:11 PM, Oliver Hartkopp >> <socketcan@hartkopp.net> wrote: >>> if (proc_dir) { >>> /* unique socket address as filename */ >>> sprintf(bo->procname, "%lu", sock_i_ino(sk)); >>> bo->bcm_proc_read = proc_create_data(bo->procname, 0644, >>> proc_dir, >>> &bcm_proc_fops, sk); >>> + if (!bo->bcm_proc_read) { >>> + ret = -ENOMEM; >>> + goto fail; >>> + } >> >> Well, I meant we need to call proc_create_data() once per socket, >> so we need a check before proc_create_data() too. > > Hmm, bo->bound should guarantee it, so never mind, your patch > looks fine.
|  |