[lkml]   [2016]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH/RFT v2 08/17] ARM: davinci: hawk: add full constraints for ohci plat boot
On Tue, Oct 25, 2016 at 12:28 PM, Sekhar Nori <> wrote:
> On Monday 24 October 2016 10:16 PM, wrote:
>> From: Axel Haslam <>
>> The phy framework requests an optional "phy" regulator. If it does
>> not find one, it returns -EPROBE_DEFER. In the case of non-DT based boot
>> for the omap138-lcdk board, this would prevent the usb11 phy to probe
>> correctly and ohci would not enumerate.
>> By calling "regulator_has_full_constraints", An error would be returned
> nit: prefer regulator_has_full_constraints()
>> instead of DEFER for the "optional" regulator, and the probe of
>> the phy driver can continue normally without a regulator.
>> Signed-off-by: Axel Haslam <>
> Looks good to me. Just drop the "hawk: from subject line since you also
> touch da830 evm. I am not sure what "ohci plat boot" means. How about
> the following:
> "ARM: davinci: da8xx: fix OHCI PHY probe for non-DT boot"

Will do.


> Thanks,
> Sekhar

 \ /
  Last update: 2016-10-25 12:32    [W:0.089 / U:1.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site