[lkml]   [2016]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration.
Hi Sekar,

On Tue, Oct 25, 2016 at 10:10 AM, Sekhar Nori <> wrote:
> On Monday 24 October 2016 10:16 PM, wrote:
>> From: David Lechner <>
>> The CFGCHIP registers are used by a number of devices, so using a syscon
>> device to share them. The first consumer of this will by the phy-da8xx-usb
>> driver.
>> Signed-off-by: David Lechner <>
>> [Axel: minor fix: change id to -1]
> Can you please clarify this change? There could be other syscon devices
> on the chip for other common registers. Why use the singular device-id?

in the case of non DT boot, the phy driver is looking for "syscon" :

d_phy->regmap = syscon_regmap_lookup_by_pdevname("syscon");

if we register the syscon driver with id = 0, the actual name of the syscon
device will be "syscon.0" and the phy driver will fail to probe, because
the strncmp match in the syscon driver (syscon_match_pdevname)
will fail.

should i change the phy driver instead?


>> Signed-off-by: Axel Haslam <>
> Thanks,
> Sekhar

 \ /
  Last update: 2016-10-25 11:39    [W:0.185 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site